Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix mock mpp store will output none data for count(empty-set) #50856

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

planner: fix mock mpp store will output none data for count(empty-set) #50856

wants to merge 6 commits into from
+96 −6

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 31, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #50893

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jan 31, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.8577%. Comparing base (7cdab19) to head (d3db647).
Report is 2173 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #50856        +/-   ##
================================================
+ Coverage   70.5964%   70.8577%   +0.2613%     
================================================
  Files          1466       1566       +100     
  Lines        434131     480279     +46148     
================================================
+ Hits         306481     340315     +33834     
- Misses       108495     117482      +8987     
- Partials      19155      22482      +3327
Flag Coverage Δ
integration 32.4460% <57.8947%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (ø)
parser ∅ <ø> (∅)
br 56.5777% <ø> (+10.7744%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2024
@AilinKid AilinKid changed the title planner: fix mock mpp store will output none data for sum(empty-set) planner: fix mock mpp store will output none data for count(empty-set) Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 2, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-02 08:24:53.593561108 +0000 UTC m=+1726735.157858799: ☑️ agreed by guo-shaoge.
  • 2024-02-02 09:54:43.482976829 +0000 UTC m=+1732125.047274520: ☑️ agreed by qw4990.

@tiprow tiprow
Copy link

tiprow bot commented Feb 2, 2024

@AilinKid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 2c627ac link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,hawkingrei,qw4990]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AilinKid
fix mock mpp store will output none data for sum(empty-set)
2da4fbb 
Signed-off-by: AilinKid <[email protected]>
@AilinKid
add test
b53d215 
Signed-off-by: AilinKid <[email protected]>
@AilinKid
fmt
0c3459c 
Signed-off-by: AilinKid <[email protected]>
@AilinKid
encapsulate func
c57d454 
Signed-off-by: AilinKid <[email protected]>
@AilinKid
.
fe55481 
Signed-off-by: AilinKid <[email protected]>
@AilinKid
.
d3db647 
Signed-off-by: AilinKid <[email protected]>
@AilinKid
Copy link
Contributor Author

AilinKid commented Feb 4, 2024

/retest

@tiprow tiprow
Copy link

tiprow bot commented Feb 4, 2024

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 17, 2024

@AilinKid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-mysql-client-test d3db647 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/mysql-test d3db647 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev d3db647 link true /test check-dev
idc-jenkins-ci-tidb/unit-test d3db647 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

planner: mpp-agg output wrong result for empty set in the mock handler of unistore
4 participants
@AilinKid @hawkingrei @guo-shaoge @qw4990